fix: Add missing redirects for /integrations/slack/ and /integrations/project-mgmt/jira/#17626
Open
fix: Add missing redirects for /integrations/slack/ and /integrations/project-mgmt/jira/#17626
Conversation
…/project-mgmt/jira/ The wildcard redirect in redirects.js (/product/integrations/:path* -> /integrations/:path*) strips the /product/ prefix but doesn't account for integration pages that sit under subcategories. This causes 404s for: - /product/integrations/slack/ -> /integrations/slack/ (should be /integrations/notification-incidents/slack/) - /product/integrations/project-mgmt/jira/ -> /integrations/project-mgmt/jira/ (should be /integrations/issue-tracking/jira/) Both of these paths are linked from the Sentry UI codebase.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/integrations/slack/to/integrations/notification-incidents/slack//integrations/project-mgmt/jira/to/integrations/issue-tracking/jira/Problem
The wildcard redirect in
redirects.js(/product/integrations/:path*→/integrations/:path*) strips the/product/prefix but doesn't handle integration pages that live under subcategories. This causes 404s when users hit these URLs from links in the Sentry UI:/product/integrations/slack/→ wildcard turns it into/integrations/slack/→ 404 (actual page is at/integrations/notification-incidents/slack/)/product/integrations/project-mgmt/jira/#jira-server→ wildcard turns it into/integrations/project-mgmt/jira/→ 404 (actual page is at/integrations/issue-tracking/jira/)Where these links exist in
getsentry/sentry:/product/integrations/slack/—src/sentry_plugins/slack/README.rst/product/integrations/slack/#upgrading-slack—src/sentry/templates/sentry/integrations/slack/reauth-introduction.html(user-facing during Slack reauth)/product/integrations/project-mgmt/jira/#jira-server— locale translation files (django.po)Fix
Added two simple redirects in
middleware.tsto catch the post-wildcard paths and route them to the correct canonical pages.