Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe PR upgrades the commander dependency to v14.0.3 and reorganizes the CLI: adds multi-line examples and security/help text, implements command grouping via a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 39: The package.json currently pins "commander": "^14.0.3" which requires
Node.js 20+ (used for the .commandsGroup() API in src/index.ts); update
package.json to either add an "engines": { "node": ">=20" } field to declare the
new runtime floor, or if you must remain Node 18-compatible, change the
commander dependency back to a 13.x release (e.g. ^13) and adjust any use of
.commandsGroup() in src/index.ts accordingly.
In `@src/index.ts`:
- Around line 29-35: Update the CLI description string in src/index.ts (the
.description(...) call) to stop showing the raw NWC secret in the command-line
example; instead show a secure pattern such as passing a file path or using a
prompt flag (e.g., replace "--connection-secret nostr+walletconnect://..." with
something like "--connection-secret-file /path/to/secret" or
"--connection-secret-stdin" in the examples), and adjust any example lines
referencing get-balance / pay-invoice accordingly so the examples demonstrate
reading the secret from a file or stdin rather than exposing the raw
nostr+walletconnect URI.
- Around line 41-54: The help text block is being attached to all commands via
addHelpText("afterAll", ...) causing connection-secret guidance to appear on
subcommands; change the hook key to "after" so the text is only shown on the
top-level help. Locate the addHelpText call in src/index.ts (the call that
currently uses "afterAll" with the Connection Secret Resolution / Security text)
and replace "afterAll" with "after" so subcommand help no longer includes the
wallet/connection-secret guidance.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d560046b-f15f-443e-84f1-4de50ad9dd62
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
package.jsonsrc/index.ts
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
| .description( | ||
| "CLI for Nostr Wallet Connect (NIP-47) with lightning tools\n\n" + | ||
| " Examples:\n" + | ||
| " $ alby-cli --connection-secret /path/to/secret.key get-balance\n" + |
There was a problem hiding this comment.
by default we shouldn't need to pass a secret. Can this be removed?
And is it really good to have more than one example here? doesn't this duplicate the help and waste context?
2 participants
Tried to cleanup the help menu for a bit and add some structure by separating the most common actions from very advanced ones:
Summary by CodeRabbit
New Features
Documentation
Chores