Add more registers

[jktjkt]

The histogram in particular is a nice feature :). Here's how it looks in the vendor's SW (a few minutes after I captured the packet trace, so some values have changed):

And here's the pykmp's output:

[...]
 689 → <unknown reg 689>            = 74260 no unit (number)
 690 → <unknown reg 690>            = 0 no unit (number)
 691 → <unknown reg 691>            = 0.900 l/h
 692 → Volume in flow bucket 1      = 0.250 l
 697 → Volume in flow bucket 2      = 0.000 m³
 698 → Volume in flow bucket 3      = 0.000 m³
 699 → Volume in flow bucket 4      = 0.019 m³
 700 → Volume in flow bucket 5      = 0.023 m³
 701 → Volume in flow bucket 6      = 0.488 m³
 702 → Volume in flow bucket 7      = 0.305 m³
 703 → Volume in flow bucket 8      = 0.000 m³
 704 → Volume in flow bucket 9      = 0.000 m³
 705 → Volume in flow bucket 10     = 0.000 m³
 706 → Volume in flow bucket 11     = 0.000 m³
 707 → Volume in flow bucket 12     = 0.000 m³
 708 → Volume in flow bucket 13     = 0.000 m³
 709 → Flow bucket 1                = 0 l/h
 710 → Flow bucket 2                = 1 l/h
 711 → Flow bucket 3                = 6 l/h
 712 → Flow bucket 4                = 32 l/h
 713 → Flow bucket 5                = 48 l/h
 714 → Flow bucket 6                = 480 l/h
 715 → Flow bucket 7                = 640 l/h
 716 → Flow bucket 8                = 800 l/h
 717 → Flow bucket 9                = 960 l/h
 718 → Flow bucket 10               = 1200 l/h
 719 → Flow bucket 11               = 1600 l/h
 720 → Flow bucket 12               = 2000 l/h
 721 → Flow bucket 13               = 15984 l/h
[...]

[gertvdijk]

is this actually time and not date? the other ones in the series are all 'date'

[jktjkt]

sorry, "date" (it's a timestamp with date & time, same as all the other values)

[gertvdijk]

Suggested change

	583: "Accoustic noise last day",
	583: "Acoustic noise last day",

[gertvdijk]

I would prefer not to have the "maybe" part of the display name.

Also, depends on the unit here, but if this is a relative number or percentage, perhaps call it "Battery SoC" or "Battery capacity remaining".

[jktjkt]

On KWM2231, it looks like a number of remaining days of battery life. On a Multical 303, there's no such register :(, and I don't have access to any other battery-operated Kamstrup meters.

[gertvdijk]

This is another huge update, cool, thanks so much!

I've reworked the git commits a bit cleaner in develop...pr-11-reworked-a-bit-wip. PTAL if you are OK with this.

My suggestion would be to use the pr-11-reworked-a-bit-wip branch as a base, amend further edits in there and then force-push it here, so it's reviewed and merged as your PR.

Once the few concerns above are handled I think it looks good for a release with the massive register/unit catalog update and then we can proceed with the functional changes. 😃

[jktjkt]

I've reworked the git commits a bit cleaner in develop...pr-11-reworked-a-bit-wip. PTAL if you are OK with this.

Looks good to me.

Maybe change 640: "Meter type text" to "water meter type" because it's only present on my KWM2231, but not on MC303. On MC303 though, there's something that I call 676: "Heat meter type text" because it returns, well, MC303 on that meter. Not sure if these is worth documenting...

I'll drop you a mail with some of these readouts so that you can decide which ones to pick and which to ignore.