Fix #12376 New Catalog: Advanced settings issue on Dashboard#12380
Merged
Conversation
1 task
dsuren1
approved these changes
May 14, 2026
Contributor
|
@ElenaGallo Kindly test it in DEV when available. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dashboard widget catalog now uses Catalog + withCatalogRequests not CompactCatalog anymore. The old CompactCatalog was using directly catalog.url, the new implementation instead build the service url using buildServiceUrl(service) where domainAliases could be malformed in some situation.
This PR improve the WMSDomainAliases to emit an array and CatalogUtils to ensure domainAliases is an array.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12376
What is the new behavior?
The WMS catalog does not break the app on save inside dashboard apps
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information