Skip to content

Further Fixes for STAC Search #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajadain wants to merge 4 commits into
base: master
Choose a base branch
from
+16 −6
Open

Further Fixes for STAC Search #2340

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a257f3
Fix STAC search endpoint reference
rajadain Dec 9, 2025
3a260c1
assets should be dict, not list
rajadain Dec 9, 2025
765c2bd
Surface links, assets to top level
rajadain Dec 9, 2025
a33a862
Fix datetime response
rajadain Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions pygeoapi/api/stac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def landing_page(api: API,
'rel': 'search',
'type': FORMAT_TYPES[F_JSON],
'title': l10n.translate('STAC API search', request.locale),
'href': f"{api.base_url}/stac-api//search?f={F_JSON}"
'href': f"{api.base_url}/stac-api/search?f={F_JSON}"
}]

return headers, status, to_json(content, api.pretty_print)
Expand Down Expand Up @@ -379,9 +379,17 @@ def search(api: API, request: Union[APIRequest, Any]) -> Tuple[dict, int, str]:
geom = from_geojson(json.dumps(feature['geometry']))
feature['bbox'] = geom.bounds

for la in ['links', 'assets']:
if feature.get(la) is None:
feature[la] = []
if feature.get('links') is None:
Copy link
Copy Markdown
Member

@tomkralidis tomkralidis May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the content model that this update is based on? Is properties.content.links and properties.content.assets part of STAC proper?

feature['links'] = feature\
.get('properties', {})\
.get('content', {})\
.get('links', [])

if feature.get('assets') is None:
feature['assets'] = feature\
.get('properties', {})\
.get('content', {})\
.get('assets', {})

stac_api_response['numberReturned'] = len(stac_api_response['features'])

Expand Down Expand Up @@ -488,18 +496,20 @@ def get_temporal(feature: dict) -> dict:
if datetime_ is None and None not in [start_datetime, end_datetime]:
LOGGER.debug('Temporal range partially exists')
elif datetime_ is not None:
value['datetime'] = datetime_
LOGGER.debug('Temporal instant exists')

LOGGER.debug('Attempting to derive temporal from GeoJSON feature')
LOGGER.debug(feature)
if feature.get('time') is not None:
if not value.get('datetime') and feature.get('time') is not None:
Copy link
Copy Markdown
Member

@tomkralidis tomkralidis May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do if value.get('datetime') is None and feature.get('time') is not None: for readability?

if feature['time'].get('timestamp') is not None:
value['datetime'] = feature['time']['timestamp']
if feature['time'].get('interval') is not None:
value['start_datetime'] = feature['time']['interval'][0]
value['end_datetime'] = feature['time']['interval'][1]

if feature['properties'].get('created') is not None:
if not value.get('datetime') \
Copy link
Copy Markdown
Member

@tomkralidis tomkralidis May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do if value.get('datetime') is None and feature['properties'].get('created') is not None: for readability?

and feature['properties'].get('created') is not None:
value['datetime'] = feature['properties']['created']

if not value:
Expand Down
Loading