Fix: Fix prompt name for scanning dependencies#155
Conversation
Changes the command name /scan-deps for consistency.
shrishabh
requested review from
QuanZhang-William,
QuinnDACollins,
capachino,
evanotero and
heltonduarte
as code owners
|
🤖 Hi @shrishabh, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This Pull Request has been reviewed. No specific changes or issues were identified, as the content of the pull request could not be retrieved for analysis.
🔍 General Feedback
- No specific feedback to provide due to inability to access pull request content.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the security:scan_deps prompt to security:scan-deps. A review comment identifies that the prompt name should be changed to security:analyze to align with the repository's Standard Operating Procedures (SOP) for security analysis, which explicitly requires the command for a comprehensive scan to be /security:analyze.
|
|
||
| server.registerPrompt( | ||
| 'security:scan_deps', | ||
| 'security:scan-deps', |
There was a problem hiding this comment.
The prompt name should be changed to security:analyze to align with the Standard Operating Procedures (SOP) defined in the repository style guide. The SOP (line 25) explicitly requires the command for a 'Comprehensive Scan' to be /security:analyze. Using security:scan-deps creates a discrepancy between the documented procedure and the implementation, which will lead to confusion when the LLM instructs the user to use a command that is not registered under that name.
| 'security:scan-deps', | |
| 'security:analyze', |
References
- The Standard Operating Procedures (SOP) for Security Analysis Guidelines (line 25) specify that the command for a Comprehensive Scan must be
/security:analyze. (link)
There was a problem hiding this comment.
This pull request refactors the prompt name for scanning dependencies from /scan_deps to /scan-deps for consistency. The changes are minimal and do not introduce any security vulnerabilities.
🔍 General Feedback
- The change is straightforward and improves the consistency of the command names.
- No new vulnerabilities were introduced.
2 participants
Changes the command name /scan-deps for consistency.