Add support to interact with a local podman installation#211
Add support to interact with a local podman installation#211NotTheEvilOne merged 3 commits intomainfrom
Conversation
6d29503 to
9aff29a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 91.41% 91.13% -0.28%
==========================================
Files 49 51 +2
Lines 2585 2887 +302
==========================================
+ Hits 2363 2631 +268
- Misses 222 256 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9aff29a to
41c4a3a
Compare
vivus-ignis
left a comment
There was a problem hiding this comment.
Please add tests. I've also added some suggestions.
5eea9cf to
0f14ce7
Compare
4d6fba8 to
01a90ec
Compare
7029e14 to
b9039cc
Compare
Code is now ready for review, I would highly appreciate your feedback @vivus-ignis. |
0dbdc21 to
67d413d
Compare
ab347bc to
08405e0
Compare
08405e0 to
537798a
Compare
537798a to
ba4cfd4
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
vivus-ignis
left a comment
There was a problem hiding this comment.
Please add proper cli error messages when wrong arguments are passed to pull (maybe it also applies to other subcommands).
I would also add tests for non-happy paths, at your discretion however.
Please elaborate in more detail what you mean with "proper cli error messages": This is the default output and already pretty detailed. Based on the audience of the CLI tools I would expect our users to be able to figure out what option is missing. Furthermore please consider to open an issue if error messages may not contain the details you would expect. This is out of scope for this PR. |
|
Proper CLI error message (and actually a proper error message in general) is a message that gives a hint to a user on what he/she can do next to fix the problem. Here's an example from docker In my opinion, "None" is not an error message at all. |
What this PR does / why we need it:
This PR adds support to interact with a local podman installation.
Which issue(s) this PR fixes:
Closes #199
Closes #200