fix(learn): fix workshop progress bar calculation and deduplicate cha… - #1826
Open
rohanesor wants to merge 1 commit into
Open
fix(learn): fix workshop progress bar calculation and deduplicate cha…#1826rohanesor wants to merge 1 commit into
rohanesor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1785
Description
Fixes an issue where workshops and labs (e.g. in JS and Python certs) display incorrect progress (adding 10% per step instead of 20%) and only reach 50% completion when all steps are finished.
Motivation & Context
Block.fromJsonparseddata['challengeOrder']without deduplicating challenge IDs. When duplicate challenge entries existed in block metadata,block.challenges.lengthbecame double the actual step count (e.g. 10 instead of 5), while user progress only records 1 completion per unique challenge ID (e.g. 5). Thus5 / 10 = 50%.Changes Made
mobile-app/lib/models/learn/curriculum_model.dart: DeduplicatedchallengeOrderbyidinBlock.fromJsonto ensurechallengesandchallengeTilescontain accurate unique step counts.mobile-app/lib/ui/views/learn/widgets/pass/pass_widget_view.dart: Added.clamp(0.0, 1.0)and.clamp(0, 100)bounds safety to progress indicators.Checklist