fix(learn): hide console button for non-JS challenges - #1825
Open
rohanesor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1666
Description
Hides the JavaScript console button (
Icons.terminal) from the challenge action bar for non-JS challenges (such as HTML/CSS-only steps).Motivation & Context
Previously, the console button appeared for all interactive challenges regardless of language. For HTML/CSS challenges, the JS console is irrelevant and shouldn't be displayed.
Changes Made
mobile-app/lib/ui/views/learn/challenge/challenge_view.dart: AddedhasJsFilecheck that inspectschallenge.filesforExt.jsorExt.jsxextensions, rendering the console_panelIconButtonconditionallyif (hasJsFile).Checklist