feat(cli): add kind filter to select sessions or tools#341
Open
S1M0N38 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a kind discriminator to the CLI filtering layer so sidekick.cli.select() pickers can be restricted to either running sessions or available tools, addressing the limitation described in #340.
Changes:
- Extends
sidekick.cli.Filterwithkind?: "session" | "tool". - Implements
kindmatching insidekick.cli.state.is()based on whethert.sessionis present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| and (filter.cwd == nil or (t.session and t.session.cwd == Session.cwd())) | ||
| and (filter.external == nil or filter.external == t.external) | ||
| and (filter.installed == nil or filter.installed == t.installed) | ||
| and (filter.kind == nil or (filter.kind == "session") == (t.session ~= nil)) |
Add `kind` ("session" | "tool") to sidekick.cli.Filter so users can build pickers restricted to running sessions or available tools. No existing filter field can express this: the sole discriminator is `session ~= nil`, untestable with the strict `==` match (nil ~= false), and every proxy breaks for mux backends where `terminal == nil` on both kinds. Pure filter -- one clause in state.is, no change to row generation.
Closes folke#340.
S1M0N38
force-pushed
the
feat/filter-kind
branch
from
July 16, 2026 12:03
0ed9c33 to
68260ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
kind("session" | "tool") to sidekick.cli.Filter so users can build pickers restricted to running sessions or available tools. No existing filter field can express this: the sole discriminator issession ~= nil, untestable with the strict==match (nil ~= false), and every proxy breaks for mux backends whereterminal == nilon both kinds. Pure filter -- one clause in state.is, no change to row generation.Related Issue(s)
Closes #340.