Conversation
|
Staged preview of the updated flutter.dev site (updated for commit cea72ce): https://flutter-dev-230821--www-pr13796-cli-bc-bza14d47.web.app |
There was a problem hiding this comment.
Code Review
This pull request adds a new documentation page explaining a breaking change that restricts command-line flags on prebuilt Android release binaries. Feedback on the documentation suggests correcting the highlighted line range in the XML code block to exclude the unrelated <activity> tag, and removing or replacing a Google-internal shortlink with a public reference.
| add `<meta-data>` elements under the `<application>` tag in | ||
| your `android/app/src/main/AndroidManifest.xml` file: | ||
|
|
||
| ```xml title="AndroidManifest.xml" highlightLines=6-13 |
There was a problem hiding this comment.
The highlightLines range is set to 6-13. However, line 13 of the code block is <activity>, which is not part of the metadata configuration being demonstrated. The metadata configuration ends on line 12 (android:value="false" />).
Consider updating the range to 6-12 to avoid highlighting unrelated code:
```xml title="AndroidManifest.xml" highlightLines=6-12|
|
||
| Design document: | ||
|
|
||
| * [go/flutter-android-secure-intents](http://goto.google.com/flutter-android-secure-intents) |
There was a problem hiding this comment.
|
Staged preview of the updated docs.flutter.dev site (updated for commit cea72ce): https://flutter-docs-prod--docs-pr13796-cli-bc-9xazfynb.web.app |
Description of what this PR is changing or adding, and why:
Adds breaking change docs for restricting setting engine configuration flags on the command line when running a Flutter Android app in release mode with a prebuilt binary, i.e.
flutter run --release --use-application-binary.Issues fixed by this PR (if any):
Part of flutter/flutter#190461
PRs or commits this PR depends on (if any):
flutter/flutter#190870
Presubmit checklist
of 80 characters or fewer.