CUJ index [land silently] - #13769
Conversation
Extract generic two-column filterable index layout styles and sidebar/search components from learning resources into reusable filterable_index.dart and _filterable-index.scss.
Adds the canonical Critical User Journeys (CUJs) data, data model, filterable index page components, and styling for /ai/flutter-bench/cujs.
|
Staged preview of the updated docs.flutter.dev site (updated for commit 34c640f): https://flutter-docs-prod--docs-pr13769-cuj-index-ucwmiabz.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit a4f01fb): https://flutter-dev-230821--www-pr13769-cuj-index-eerbuymc.web.app |
# Conflicts: # sites/docs/lib/_sass/components/_filterable-index.scss # sites/docs/lib/src/components/pages/filterable_index.dart # sites/docs/lib/src/components/pages/learning_resource_filters_sidebar.dart
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Critical User Journey (CUJ) index page, including a catalog of journeys, search and filter capabilities, and responsive styling. The feedback highlights several critical syntax errors where .text(...) is used instead of Text(...), which will cause compilation failures. Additionally, the reviewer pointed out potential runtime crashes related to unsafe type casting of page data and checkbox states, a potential exception from calling setState on an unmounted widget, and recommended using a more specific CSS selector for querying card elements.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lamek
left a comment
lamek
left a comment
There was a problem hiding this comment.
LGTM on the docs stuff. I added some fixes and suggestions. I'll leave the code review to Parker and Killian.
Page I reviewed: https://flutter-docs-prod--docs-pr13769-cuj-index-ucwmiabz.web.app/ai/flutter-bench/cujs
|
|
||
| [FlutterBench]: /ai/flutter-bench | ||
|
|
||
| [critical user journey]: https://static.googleusercontent.com/media/sre.google/en//static/pdf/art-of-slos-handbook-a4.pdf |
There was a problem hiding this comment.
Is this the correct thing to link to? I see the section on user journeys, but the PDF is mostly about SLOs.
There was a problem hiding this comment.
ah shoot that isn't right, I meant to return to this
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
I'm a bit confused here. I looked at the staged site and I can't find the /ai/flutter-bench page that is referred to in the PR. I know that @jesskuras's restructuring PR does have that page, so is this PR waiting for her PR to land? If so, maybe mark this as draft...
The path will change depending on Jess's change's, so I'm just waiting for that PR to land to know what to update it to. |
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Cool! Generally looking good to me. Some small suggestions:
Co-authored-by: Parker Lougheed <parlough@gmail.com>
5 participants
Description of what this PR is changing or adding, and why:
This PR adds a CUJ index page, which is landed silently for now. This is an effort to break up the currently massive #13691