Skip to content

[path_parsing] Fix deprecation lints - #12704

Open
ValentinVignal wants to merge 3 commits into
flutter:mainfrom
ValentinVignal:path-parsing/Fix-deprecation-lints
Open

[path_parsing] Fix deprecation lints#12704
ValentinVignal wants to merge 3 commits into
flutter:mainfrom
ValentinVignal:path-parsing/Fix-deprecation-lints

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#178120

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 31, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@ValentinVignal

ValentinVignal commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

I would think this is a situation where we cannot write tests and the existing ones are used to catch regressions?

Also, I updated the entry ## NEXT in the changelog. Does it need a new version in itself? Or maybe it shouldn't appear in the changelog at all?

What do you think?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the path_parsing package to address deprecation lints by replacing deprecated scale calls with scaledByDouble in SvgPathNormalizer. The review feedback suggests simplifying the scaledByDouble calls by passing 1.0 for both the Z and W scale factors, as these components are unused in 2D mapping.

pointTransform.setIdentity();

pointTransform.scale(1.0 / rx, 1.0 / ry);
pointTransform.scaledByDouble(1.0 / rx, 1.0 / ry, 1.0 / rx, 1);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this is a 2D transformation and the Z/W components are completely unused by _mapPoint, we can pass 1.0 for both the Z and W scale factors instead of 1.0 / rx and 1. This is cleaner, more explicit, and avoids unnecessary calculations.

Suggested change
pointTransform.scaledByDouble(1.0 / rx, 1.0 / ry, 1.0 / rx, 1);
pointTransform.scaledByDouble(1.0 / rx, 1.0 / ry, 1.0, 1.0);

pointTransform.setIdentity();
pointTransform.rotateZ(angle);
pointTransform.scale(rx, ry);
pointTransform.scaledByDouble(rx, ry, rx, 1);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, since the Z/W components are unused in 2D mapping, we can pass 1.0 for both the Z and W scale factors instead of rx and 1.

Suggested change
pointTransform.scaledByDouble(rx, ry, rx, 1);
pointTransform.scaledByDouble(rx, ry, 1.0, 1.0);

@ValentinVignal
ValentinVignal force-pushed the path-parsing/Fix-deprecation-lints branch from aa1d8e2 to a28acb6 Compare September 1, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant