[vector_graphics] Fix deprecation lints

[ValentinVignal]

Part of flutter/flutter#178120

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request updates vector_graphics.dart to address deprecation lints by replacing translate and scale with translateByDouble and scaledByDouble, and corrects a typo in a comment. The reviewer suggests simplifying the new matrix transformation calls by omitting optional arguments that match their default values.

[gemini-code-assist]

The optional arguments for translateByDouble and scaledByDouble can be omitted because they match their default values (y = 0.0, z = 0.0, w = 1.0 for translateByDouble, and w = 1.0 for scaledByDouble). Simplifying these calls improves code readability.

Note that since this is a 2D graphic, scaling the Z-axis is also unnecessary, so ..scaledByDouble(-1, 1) could also be used.

Suggested change

	..translateByDouble(pictureInfo.size.width, 0, 0, 1)
	..scaledByDouble(-1, 1, -1, 1),
	..translateByDouble(pictureInfo.size.width)
	..scaledByDouble(-1, 1, -1)

[ValentinVignal]

That's not true, those methods require 4 arguments

[ValentinVignal]

I would think this is a situation where we cannot write tests and the existing ones are used to catch regressions?

Also, I added an entry ## NEXT in the changelog. Does it need a new version in itself? Or maybe it shouldn't appear in the changelog at all?

What do you think?

[andywolff]

This breaks the tests. Please use scaleByDouble here, not scale(d)ByDouble. scaleByDouble mutates the subject whereas scaledByDouble returns a new matrix, which is ignored in this case. PR looks good otherwise

[ValentinVignal]

Nice catch, and sorry about that. I fixed it in Use scaleByDouble instead of scaledByDouble

[andywolff]

Oh also, to respond to your question explicitly:

I would think this is a situation where we cannot write tests and the existing ones are used to catch regressions?

Yes, existing tests cover this case. They even broke and identified the problem in my other comment. See "Dashboard Checks". Specifically, vector_graphics_test.dart: Respects text direction was broken

Also, I added an entry ## NEXT in the changelog. Does it need a new version in itself? Or maybe it shouldn't appear in the changelog at all?

What do you think?

I think ## NEXT is appropriate here

[andywolff]

Thanks, LGTM

[auto-submit]

autosubmit label was removed for flutter/packages/12702, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.