[various] Upgrade googletest to v1.15.2#11586
Open
Gustl22 wants to merge 2 commits intoflutter:mainfrom
Open
Conversation
93f775b to
837e25a
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the googletest version to 1.15.2 across several packages, including camera_windows, file_selector, local_auth, pigeon, and url_launcher. Feedback indicates that a CHANGELOG.md entry should be added for the changes made to the pigeon package's test infrastructure.
| FetchContent_Declare( | ||
| googletest | ||
| URL https://github.com/google/googletest/archive/release-1.11.0.zip | ||
| URL https://github.com/google/googletest/archive/v1.15.2.zip |
There was a problem hiding this comment.
The changes to the test infrastructure in the pigeon package should be accompanied by a CHANGELOG.md entry, consistent with the other packages updated in this pull request (such as camera_windows and file_selector_linux).
References
- Every change to a package must be accompanied by a version bump and a CHANGELOG entry.
Contributor
Author
There was a problem hiding this comment.
Pigeons test_plugin is not published and also doesn't provide a Changelog file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running e.g. pigeon tests (
packages\pigeon\tool\test.dart) with Visual Studio 2026 gives the following error:So upgrading the google tools to v1.15.2 resolves that issue as since 1.12.1 the minimum required CMake version is 3.5.
Towards flutter/flutter#185597
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2