Skip to content

[various] Upgrade googletest to v1.15.2#11586

Open
Gustl22 wants to merge 2 commits intoflutter:mainfrom
Gustl22:185597-google-tools
Open

[various] Upgrade googletest to v1.15.2#11586
Gustl22 wants to merge 2 commits intoflutter:mainfrom
Gustl22:185597-google-tools

Conversation

@Gustl22
Copy link
Copy Markdown
Contributor

@Gustl22 Gustl22 commented Apr 26, 2026

Running e.g. pigeon tests (packages\pigeon\tool\test.dart) with Visual Studio 2026 gives the following error:

##############################
# Generating platform_test/ output [start time 22:58:25]
Generation complete!
##############################
# Running windows_unittests [start time 22:58:29]
Building Windows application...                                 
CMake Error at D:/Tmp/Coding/git/flutter/packages/packages/pigeon/platform_tests/test_plugin/example/build/windows/x64/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


Building Windows application...                                     6,9s
Unable to generate build files
# Failed, exit code: 1

Process finished with exit code 1

So upgrading the google tools to v1.15.2 resolves that issue as since 1.12.1 the minimum required CMake version is 3.5.

Towards flutter/flutter#185597

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the googletest dependency version from 1.11.0 to 1.15.2 in the CMakeLists.txt files for the camera, file_selector, local_auth, pigeon, and url_launcher packages. I have no feedback to provide.

@Gustl22 Gustl22 force-pushed the 185597-google-tools branch from 93f775b to 837e25a Compare April 26, 2026 20:48
@Gustl22 Gustl22 marked this pull request as draft April 27, 2026 06:07
@Gustl22 Gustl22 marked this pull request as ready for review April 27, 2026 21:11
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the googletest version to 1.15.2 across several packages, including camera_windows, file_selector, local_auth, pigeon, and url_launcher. Feedback indicates that a CHANGELOG.md entry should be added for the changes made to the pigeon package's test infrastructure.

FetchContent_Declare(
googletest
URL https://github.com/google/googletest/archive/release-1.11.0.zip
URL https://github.com/google/googletest/archive/v1.15.2.zip
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changes to the test infrastructure in the pigeon package should be accompanied by a CHANGELOG.md entry, consistent with the other packages updated in this pull request (such as camera_windows and file_selector_linux).

References
  1. Every change to a package must be accompanied by a version bump and a CHANGELOG entry.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pigeons test_plugin is not published and also doesn't provide a Changelog file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant