[url_launcher_android] Bump gradle plugin to 9.1.1#11557
[url_launcher_android] Bump gradle plugin to 9.1.1#11557camsim99 wants to merge 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the url_launcher_android package to version 6.3.31 and bumps the Android Gradle Plugin dependency to 9.1.1. A critical issue was identified where the version 9.1.1 likely refers to the Gradle build tool rather than the Android Gradle Plugin, which will cause build failures as that version is not available in the Google Maven repository.
|
|
||
| dependencies { | ||
| classpath("com.android.tools.build:gradle:8.13.1") | ||
| classpath("com.android.tools.build:gradle:9.1.1") |
There was a problem hiding this comment.
The version 9.1.1 appears to be a Gradle version rather than an Android Gradle Plugin (AGP) version. AGP versions (the com.android.tools.build:gradle dependency) are currently in the 8.x range and do not follow the same versioning sequence as Gradle itself. Using a Gradle version for the AGP dependency will likely cause the build to fail because that version of the plugin does not exist in the Google Maven repository. If the intent is to upgrade the Gradle build tool to 9.1.1, you should update the distributionUrl in gradle-wrapper.properties and use a compatible AGP version (e.g., 8.7.x).
Bumps com.android.tools.build:gradle from 8.13.1 to 9.1.1 in packages/url_launcher/url_launcher_android.