Skip to content

[url_launcher_android] Bump gradle plugin to 9.1.1#11557

Open
camsim99 wants to merge 1 commit intoflutter:mainfrom
camsim99:update-gradle-plugin-url_launcher_android
Open

[url_launcher_android] Bump gradle plugin to 9.1.1#11557
camsim99 wants to merge 1 commit intoflutter:mainfrom
camsim99:update-gradle-plugin-url_launcher_android

Conversation

@camsim99
Copy link
Copy Markdown
Contributor

Bumps com.android.tools.build:gradle from 8.13.1 to 9.1.1 in packages/url_launcher/url_launcher_android.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the url_launcher_android package to version 6.3.31 and bumps the Android Gradle Plugin dependency to 9.1.1. A critical issue was identified where the version 9.1.1 likely refers to the Gradle build tool rather than the Android Gradle Plugin, which will cause build failures as that version is not available in the Google Maven repository.


dependencies {
classpath("com.android.tools.build:gradle:8.13.1")
classpath("com.android.tools.build:gradle:9.1.1")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 9.1.1 appears to be a Gradle version rather than an Android Gradle Plugin (AGP) version. AGP versions (the com.android.tools.build:gradle dependency) are currently in the 8.x range and do not follow the same versioning sequence as Gradle itself. Using a Gradle version for the AGP dependency will likely cause the build to fail because that version of the plugin does not exist in the Google Maven repository. If the intent is to upgrade the Gradle build tool to 9.1.1, you should update the distributionUrl in gradle-wrapper.properties and use a compatible AGP version (e.g., 8.7.x).

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Apr 23, 2026
@camsim99 camsim99 requested a review from a team April 27, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants