Skip to content

fix: clarify widget rebuild counts require debug mode #9985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enesbugrahankilic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clarify widget rebuild counts require debug mode #9985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 57 additions & 26 deletions packages/devtools_app/lib/src/screens/performance/panes/frame_analysis/frame_analysis.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,41 +91,72 @@ class FlutterFrameAnalysisView extends StatelessWidget {
],
if (rebuilds.isNullOrEmpty) ...[
const PaddedDivider.noPadding(),
ValueListenableBuilder<ServiceExtensionState>(
valueListenable: serviceConnection
.serviceManager
.serviceExtensionManager
.getServiceExtensionState(
extensions.countWidgetBuilds.extension,
),
builder: (context, extensionState, _) {
if (!extensionState.enabled) {
return Row(
children: [
const Text(
'To see widget rebuilds for Flutter frames, enable',
),
Flexible(
child: ServiceExtensionCheckbox(
serviceExtension: extensions.countWidgetBuilds,
showDescription: false,
),
),
],
Builder(
builder: (context) {
final isProfileBuild =
serviceConnection
.serviceManager
.connectedApp
?.isProfileBuildNow ??
false;
final rebuildCountsAvailable = serviceConnection
.serviceManager
.serviceExtensionManager
.isServiceExtensionAvailable(
extensions.countWidgetBuilds.extension,
);

// Widget rebuild counts rely on debug-only service extensions.
// Avoid showing a disabled checkbox in profile mode.
if (isProfileBuild || !rebuildCountsAvailable) {
return const Text(
'Rebuild information not available for this frame. Widget '
'rebuild counts are only available when running an app in '
'debug-mode.',
);
}
return const SizedBox();

return ValueListenableBuilder<ServiceExtensionState>(
valueListenable: serviceConnection
.serviceManager
.serviceExtensionManager
.getServiceExtensionState(
extensions.countWidgetBuilds.extension,
),
builder: (context, extensionState, _) {
if (!extensionState.enabled) {
return Row(
children: [
const Text(
'To see widget rebuilds for Flutter frames, enable',
),
Flexible(
child: ServiceExtensionCheckbox(
serviceExtension: extensions.countWidgetBuilds,
showDescription: false,
),
),
],
);
}
// Extension is on, but this frame still has no rebuild data.
if (rebuilds == null) {
return const Text(
'Rebuild information not available for this frame.',
);
}
return const SizedBox();
},
);
},
),
Comment on lines +94 to 152

@gemini-code-assist gemini-code-assist Bot Aug 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] The Builder widget here is unnecessary and introduces extra nesting and closure allocations. We can use Dart's collection-if/else support directly within the widget list by inlining the conditions, which makes the code cleaner and more idiomatic.

            if ((serviceConnection.serviceManager.connectedApp?.isProfileBuildNow ?? false) ||
                !serviceConnection.serviceManager.serviceExtensionManager
                    .isServiceExtensionAvailable(
                  extensions.countWidgetBuilds.extension,
                ))
              const Text(
                'Rebuild information not available for this frame. Widget '
                'rebuild counts are only available when running an app in '
                'debug-mode.',
              )
            else
              ValueListenableBuilder<ServiceExtensionState>(
                valueListenable: serviceConnection
                    .serviceManager
                    .serviceExtensionManager
                    .getServiceExtensionState(
                      extensions.countWidgetBuilds.extension,
                    ),
                builder: (context, extensionState, _) {
                  if (!extensionState.enabled) {
                    return Row(
                      children: [
                        const Text(
                          'To see widget rebuilds for Flutter frames, enable',
                        ),
                        Flexible(
                          child: ServiceExtensionCheckbox(
                            serviceExtension: extensions.countWidgetBuilds,
                            showDescription: false,
                          ),
                        ),
                      ],
                    );
                  }
                  // Extension is on, but this frame still has no rebuild data.
                  if (rebuilds == null) {
                    return const Text(
                      'Rebuild information not available for this frame.',
                    );
                  }
                  return const SizedBox();
                },
              ),
References
  1. Avoid unnecessary widget nesting and use idiomatic Dart collection-if/else for cleaner widget structure. (link)

],
if (rebuilds == null)
const Text('Rebuild information not available for this frame.')
else if (rebuilds.isEmpty)
if (rebuilds != null && rebuilds.isEmpty)
const Text(
'No widget rebuilds occurred for widgets that were directly '
'created in your project.',
)
else ...[
else if (rebuilds != null) ...[
const SizedBox(height: defaultSpacing),
Expanded(
child: RebuildTable(
Expand Down