Skip to content

Comments

Adjust GoogleSheetExtractor row data extraction#2222

Merged
norberttech merged 2 commits intoflow-php:1.xfrom
stloyd:bugfix/2221
Feb 21, 2026
Merged

Adjust GoogleSheetExtractor row data extraction#2222
norberttech merged 2 commits intoflow-php:1.xfrom
stloyd:bugfix/2221

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Feb 21, 2026

Resolves: #2221

Change Log


Added

Fixed

Changed

  • Adjust `GoogleSheetExtractor` row data extraction

Removed

Deprecated

Security


Running locally (spreadsheet with ~6k rows):

Before

stloyd@MacBookPro ordering-frames % time bin/console import:ava 12_0DATNId9FagnsATjyQ4K3kOw9wdyrK0E4zQf__PYE
bin/console import:ava 12_0DATNId9FagnsATjyQ4K3kOw9wdyrK0E4zQf__PYE  1.03s user 0.13s system 7% cpu 14.756 total

After

stloyd@MacBookPro ordering-frames % time bin/console import:ava 12_0DATNId9FagnsATjyQ4K3kOw9wdyrK0E4zQf__PYE
bin/console import:ava 12_0DATNId9FagnsATjyQ4K3kOw9wdyrK0E4zQf__PYE  0.97s user 0.13s system 12% cpu 8.441 total

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.99%. Comparing base (363c851) to head (9b42496).
⚠️ Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #2222      +/-   ##
==========================================
+ Coverage   82.77%   82.99%   +0.21%     
==========================================
  Files        1334     1334              
  Lines       49383    49378       -5     
==========================================
+ Hits        40879    40983     +104     
+ Misses       8504     8395     -109     
Components Coverage Δ
etl 90.44% <ø> (+0.86%) ⬆️
cli 85.76% <ø> (ø)
lib-array-dot 94.82% <ø> (ø)
lib-azure-sdk 60.01% <ø> (ø)
lib-doctrine-dbal-bulk 95.16% <ø> (ø)
lib-filesystem 83.40% <ø> (ø)
lib-types 88.88% <ø> (+1.50%) ⬆️
lib-parquet 68.25% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.95% <ø> (ø)
bridge-filesystem-azure 89.38% <ø> (ø)
bridge-monolog-http 97.45% <ø> (ø)
bridge-openapi-specification 91.50% <ø> (ø)
symfony-http-foundation 74.11% <ø> (ø)
adapter-chartjs 84.72% <ø> (ø)
adapter-csv 88.65% <ø> (ø)
adapter-doctrine 92.00% <ø> (ø)
adapter-elasticsearch 92.78% <ø> (ø)
adapter-google-sheet 98.96% <100.00%> (+1.91%) ⬆️
adapter-http 67.91% <ø> (ø)
adapter-json 87.61% <ø> (ø)
adapter-logger 47.36% <ø> (ø)
adapter-meilisearch 91.66% <ø> (ø)
adapter-parquet 79.29% <ø> (ø)
adapter-text 81.25% <ø> (ø)
adapter-xml 82.07% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 0d5c45d into flow-php:1.x Feb 21, 2026
24 checks passed
@stloyd stloyd deleted the bugfix/2221 branch February 21, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: GoogleSheet adapter waste resource by doing duplicated loop over row data

2 participants