Skip to content

Stop outgoing animations during blend to prevent jitter #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tracygardner wants to merge 4 commits into from
+14 −1
Closed

Stop outgoing animations during blend to prevent jitter #599

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
705c5ba
Defer capsule shape update until after animation blend completes
claude May 3, 2026
3dd1e40
Revert "Defer capsule shape update until after animation blend comple…
claude May 3, 2026
310ab7a
Stop outgoing animation before blend to prevent trigger intersection …
claude May 3, 2026
1a7b8fd
Keep vertical capsule for Fly animation when character is on a surface
claude May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion api/animate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ const determineDesiredShapeType = (animationName) => {
return "vertical";
};

const isOnSurface = (physicsMesh) => {
return typeof flock?.checkIfOnSurface === "function" &&
flock.checkIfOnSurface(physicsMesh);
};

const updateCapsuleShapeForAnimation = (physicsMesh, animationName) => {
if (
!physicsMesh ||
Expand All @@ -28,7 +33,15 @@ const updateCapsuleShapeForAnimation = (physicsMesh, animationName) => {
return;
}

const desiredShapeType = determineDesiredShapeType(animationName);
let desiredShapeType = determineDesiredShapeType(animationName);

// The horizontal capsule is designed for airborne movement. When a Fly
// animation is used on a surface (e.g. swimming), keep the vertical capsule
// so the character doesn't become unstable on slopes near the water's edge.
if (desiredShapeType === "horizontal-fly" && isOnSurface(physicsMesh)) {
desiredShapeType = "vertical";
}

if (!physicsMesh.metadata) physicsMesh.metadata = {};

if (physicsMesh.metadata.currentPhysicsShapeType === desiredShapeType) {
Expand Down
Loading