node: fix wrong hash algorithm#539
Merged
Merged
Conversation
This reverts commit f8fb302.
To avoid mistakes in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #537 (comment) , I changed the
algofield of entry tointegrity_algo, which is tarball's hash algorithm, not for CAFS. It was not fully tested after the change (To be frank, I forgot why I wrotesha512in the first place 😢 ). For CAFS, pnpm always usessha512:https://github.com/pnpm/pnpm/blob/8695496f58edf54836d440b01a862b46eaa7f497/store/cafs/src/index.ts#L31
This PR reverts the mistake and adds the comment to avoid future confusion. It's tested in the field with an actual lockfile and pnpm ran fine without errors.