node: Fix pnpm incompatible handling of long tarball package dir names - #519
Merged
Conversation
WhyKickAmooCow
marked this pull request as draft
March 25, 2026 09:08
WhyKickAmooCow
marked this pull request as ready for review
March 25, 2026 09:13
Contributor
Author
|
Relevant to flathub/flathub#7033 |
Collaborator
|
can you add a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages with long names, or that aren't lowercased result in directories incompatible with how pnpm expects them to be stored.
Upstream behaviour for long names in the store is specified in:
An example package that causes issues with the current implementation is
https://codeload.github.com/jeffvli/Node-MPV/tar.gz/32b4d64395289ad710c41d481d2707a7acfc228f