Skip to content

FlatGeoBuf Output for Map Visualization#780

Merged
masonwillman merged 27 commits into
masterfrom
GUI-Redesign-FlatGeoBuf
Jun 4, 2026
Merged

FlatGeoBuf Output for Map Visualization#780
masonwillman merged 27 commits into
masterfrom
GUI-Redesign-FlatGeoBuf

Conversation

@masonwillman
Copy link
Copy Markdown
Contributor

This PR includes the addition of a new WindNinja output, the FlatGeoBuf. This is used to load simulations and raw wxModel files onto the leaflet app.

Fixes #753

@latwood
Copy link
Copy Markdown
Collaborator

latwood commented Jun 4, 2026

Still looking over the code to make sure it merged with the gtiff stuff right, but already I've found some separate issues to be aware of. We might just be better off waiting to fix them until after the merge.

these problems were each just mass solver runs:

  • domain average runs without diurnal make sense to show not a date time I guess, but domain average runs with diurnal are not properly displaying the times in the legends.
  • wxModel runs, the time isn't updating for both the wxModel legend, and the simulation legend, when swapping between times.

looks like the map visualizer resolution stuff/options will have to be added after the merger as well, I didn't realize that till now. Along those lines, will need to update the C-API autotest scripts accordingly once we get all the various new NinjaSetGeoBuff() options setup.

  • missed setting flatGeoBuffFlag and flatGeoBuffFile in the assignment operator (Equals operator) of WindNinjaInputs.cpp

Copy link
Copy Markdown
Collaborator

@latwood latwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small things to look over.

Comment thread src/gui/appState.cpp
Comment thread src/ninja/OutputWriter.cpp
Comment thread src/ninja/OutputWriter.cpp Outdated
@latwood
Copy link
Copy Markdown
Collaborator

latwood commented Jun 4, 2026

Just finished looking over the code the best I could. Seems to me like the geotiff stuff merged properly. NICE!

That being said, there were some commented out sections of the multi-band geotiff code that didn't get the ninjaTime std::string to boost::local_time::local_date_time update. I will work on doing a small commit tomorrow morning with that small update (will test those sections uncommented out to be sure I got them all).

Comment thread src/gui/mainWindow.cpp
Comment thread src/gui/outputs.cpp
Comment thread src/ninja/windninja.cpp Outdated
Comment thread src/ninja/WindNinjaInputs.cpp Outdated
Comment thread src/ninja/wxModelInitialization.cpp
Comment thread src/ninja/ninja.cpp
Comment thread src/ninja/ninjafoam.cpp
Comment thread src/ninja/OutputWriter.cpp
@latwood
Copy link
Copy Markdown
Collaborator

latwood commented Jun 4, 2026

Looks good to go to me. Just have to keep in mind some of the ninjaTime issues, and the map visualizer resolution options, and the angleFromNorth stuff, in the next stage of the map visualization code work.

@masonwillman masonwillman merged commit 0f60cce into master Jun 4, 2026
6 checks passed
@masonwillman masonwillman deleted the GUI-Redesign-FlatGeoBuf branch June 4, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve map rendering and RAM usage in the GUI

2 participants