Compose code for analytics

[lehcar09]

Initial commit with fixes from previous review

Initial changes made:
Add Jetpack Compose option in EntryChoiceActivity
Removed business logic from MainActivity
Added FirebaseAnalyticsViewModel for business logic
Added ComposeMainActivity for the Jetpack Compose UI

Changes made after review
-Rename recordShare API to recordShareEvent
-Pass screenClass parameter in recordScreenView

[thatfiredev]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a Jetpack Compose version of the analytics screen, refactoring the business logic into a FirebaseAnalyticsViewModel. The changes are well-structured, separating UI from logic effectively. I've found a few areas for improvement, mainly related to fixing a bug with duplicate analytics events, improving encapsulation in the ViewModel, and adhering to Kotlin and Compose best practices. I've also noted some hardcoded strings that should be moved to resources.

[gemini-code-assist]

The analytics events recordImageView and recordScreenView are being triggered from both this DisposableEffect (on ON_CREATE and ON_RESUME) and the LaunchedEffect(pagerState) below. This will result in duplicate analytics events being sent on initial app launch. The LaunchedEffect already handles the initial state correctly. You should remove this DisposableEffect to avoid sending redundant events.

[gemini-code-assist]

The ViewModel is exposing MutableState properties publicly. This breaks encapsulation, as it allows external classes (like the UI) to modify the state directly. The common practice is to expose immutable State properties to the UI and keep the MutableState private to the ViewModel.

Suggested change

	val selectedImageIndex: MutableState<Int> = _selectedImageIndex
	private val _userFavoriteFood = mutableStateOf<String?>(null)
	val userFavoriteFood: MutableState<String?> = _userFavoriteFood
	private val _showFavoriteFoodDialog = mutableStateOf(false)
	val showFavoriteFoodDialog: MutableState<Boolean> = _showFavoriteFoodDialog
	val selectedImageIndex: androidx.compose.runtime.State<Int> = _selectedImageIndex
	private val _userFavoriteFood = mutableStateOf<String?>(null)
	val userFavoriteFood: androidx.compose.runtime.State<String?> = _userFavoriteFood
	private val _showFavoriteFoodDialog = mutableStateOf(false)
	val showFavoriteFoodDialog: androidx.compose.runtime.State<Boolean> = _showFavoriteFoodDialog

[gemini-code-assist]

The string for the share intent is hardcoded. For better maintainability and to support internationalization, you should move this string to a string resource file (strings.xml). For example, you could add <string name="share_message">I'd love you to hear about %1$s</string> to your strings.xml file and use stringResource(R.string.share_message, imageTitle) here.

[gemini-code-assist]

The onClick handler is set on both the Row (via Modifier.clickable) and the RadioButton. This is redundant. To improve clarity and follow best practices, the onClick logic should be in one place. It's recommended to make the entire row clickable and disable the RadioButton's own click handler by passing null to its onClick parameter.

Suggested change

	RadioButton(
	selected = selectedItem == index,
	onClick = { selectedItem = index }
	)
	RadioButton(
	selected = selectedItem == index,
	onClick = null
	)

[gemini-code-assist]

The string for the snackbar message is hardcoded. For better maintainability and to support internationalization, you should move this string to a string resource file (strings.xml) and use context.getString() to retrieve it. You can get the context via LocalContext.current within the FavoriteFoodDialog composable.

[gemini-code-assist]

For declaring singletons or collections of constants, it's more idiomatic in Kotlin to use an object declaration instead of a class with a companion object.

Suggested change

	class Constants {
	object Constants {

[gemini-code-assist]

In the init block, when a favorite food is already present in SharedPreferences, you're calling setUserFavoriteFood(). This function writes the same value back to SharedPreferences and also sets the user property. The write to SharedPreferences is redundant. The else block should only set the user property.

Suggested change

	init {
	getUserFavoriteFood()
	if(_userFavoriteFood.value == null) {
	_showFavoriteFoodDialog.value = true
	} else {
	setUserFavoriteFood(_userFavoriteFood.value)
	}
	}
	init {
	getUserFavoriteFood()
	if(_userFavoriteFood.value == null) {
	_showFavoriteFoodDialog.value = true
	} else {
	firebaseAnalytics.setUserProperty("favorite_food", _userFavoriteFood.value)
	}
	}