fix(go): allow WithPromptFS and WithPromptDir to be used together

[dmeremyanin]

Fixes #4799

Removes the validation checks that prevented using WithPromptFS and WithPromptDir together. The options now work as documented - WithPromptDir specifies the subdirectory within the embedded filesystem (defaults to "prompts" if not set).

Includes tests covering both custom and default directory scenarios.

Checklist (if applicable):

• PR title is following https://www.conventionalcommits.org/en/v1.0.0/
• Tested (manually, unit tested, etc.)
• Docs updated (updated docs or a docs bug required)

[gemini-code-assist]

Summary of Changes

Hello @dmeremyanin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of prompt management within the Genkit Go library by allowing the WithPromptFS and WithPromptDir options to be used concurrently. This change removes a previous restriction, enabling developers to specify an embedded filesystem for prompts and then define a specific subdirectory within that filesystem, improving how prompts are organized and loaded.

Highlights

• Validation Removal: Removed validation checks that previously prevented WithPromptFS and WithPromptDir from being used simultaneously, allowing for more flexible prompt configuration.
• Enhanced Prompt Directory Handling: Enabled WithPromptDir to specify a subdirectory within an embedded filesystem provided by WithPromptFS, aligning with the documented behavior for prompt organization.
• New Test Coverage: Added comprehensive unit tests to verify the combined usage of WithPromptFS and WithPromptDir for both custom and default prompt directories, ensuring correct functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• go/genkit/genkit.go
  • Removed mutual exclusion validation for WithPromptFS and WithPromptDir options.
  • Removed redundant assignment of gOpts.PromptDir when WithPromptFS is used.
• go/genkit/genkit_test.go
  • Imported the testing/fstest package.
  • Added TestWithPromptFS function to validate the combined usage of WithPromptFS and WithPromptDir with both custom and default prompt directories.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where WithPromptFS and WithPromptDir could not be used together, despite documentation suggesting they could. The changes in go/genkit/genkit.go remove the conflicting validation logic in the apply method for genkitOptions. This fix is clean and directly solves the problem. The addition of the TestWithPromptFS test in go/genkit/genkit_test.go is excellent, as it provides good coverage for the corrected behavior, testing both custom and default prompt directories with an embedded filesystem. The changes are well-implemented and improve the usability of the prompt configuration options. Great work!