fix: build firestore resource path from event fields instead of event…#1935
Closed
IzaakGough wants to merge 1 commit into
Closed
fix: build firestore resource path from event fields instead of event…#1935IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request resolves an issue where a malformed event.source attribute in CloudEvents causes errors when creating Firestore snapshots. It updates createSnapshot and createBeforeSnapshot to use getPath(event) instead of event.source for JSON-encoded events. Additionally, regression tests have been added to verify this behavior, including cases with malformed sources and document IDs containing trailing spaces. I have no feedback to provide.
Contributor
Author
|
Closing as wrong direction for fix. This needs to be fixed upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1922
relnote: none