fix: rename task timeout kind and also apply it to scheduler#1934
Open
IzaakGough wants to merge 1 commit into
Open
fix: rename task timeout kind and also apply it to scheduler#1934IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the maximum timeout limit for scheduled functions (v2) from 540 seconds to 1800 seconds. To support this, the timeout category "task" has been renamed to "scheduledOrTask", and the constant "MAX_TASK_TIMEOUT_SECONDS" has been updated to "MAX_SCHEDULE_OR_TASK_TIMEOUT_SECONDS". Validation logic, tests, and error messages have been updated accordingly. I have no additional feedback to provide as there are no review comments.
IzaakGough
marked this pull request as ready for review
July 17, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1933
relnote: none