fix: dynamically increment prerelease versions in publish.sh#1932
Open
inlined wants to merge 2 commits into
Open
fix: dynamically increment prerelease versions in publish.sh#1932inlined wants to merge 2 commits into
inlined wants to merge 2 commits into
Conversation
inlined
force-pushed
the
inlined.fix-publish-prerelease
branch
from
July 16, 2026 22:10
3b5481e to
e1aa47a
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the prerelease versioning logic in scripts/publish.sh to check npm for existing prerelease versions in the target range and increment them if found, rather than always starting from the stable version. The reviewer noted that parsing the raw output of npm view with tail and grep is fragile and prone to errors due to output formatting variations, sorting assumptions, and a hardcoded regex. They suggested a more robust approach using Node.js and the semver package to parse the JSON output safely.
inlined
force-pushed
the
inlined.fix-publish-prerelease
branch
from
July 16, 2026 22:12
e1aa47a to
b2a1126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in
scripts/publish.shwhere prerelease publishing (e.g. running with--prerelease) would fail ifrc.0was already published on npm for that target version series, since it always bumped from the stable version. It now dynamically checks npm for any existing prerelease versions of the target version series, and performs aprereleaseincrement (e.g., torc.1) if one exists.Release Notes
relnote: none