feat: add retry support for firestore, storage and realtime database#298
feat: add retry support for firestore, storage and realtime database#298IzaakGough wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates StorageOptions, DatabaseOptions, and FirestoreOptions to inherit from EventHandlerOptions instead of RuntimeOptions, allowing the retry configuration to be dynamically set. Corresponding unit tests have been added to verify this behavior. Feedback suggests simplifying the _endpoint method in StorageOptions by leveraging super()._endpoint directly now that it inherits from EventHandlerOptions.
|
Nice work covering all three providers, and the tests for both retry=True and the default path are solid. One structural ask: # EventHandlerOptions._endpoint
event_trigger = _manifest.EventTrigger(
eventType=kwargs["event_type"],
retry=self.retry if self.retry is not None else False,
eventFilters=kwargs["event_filters"],
eventFilterPathPatterns=kwargs.get("event_filters_path_patterns"),
)then both subclasses build their filters and call |
Fixes #165
This PR maintains parity between the Python and JavaScript SDKs by adding retry support for Storage, Firestore, and Realtime Database.