Skip to content

Fix: Use credentials from FTP URIs - #19023

Open
theworker02 wants to merge 1 commit into
files-community:mainfrom
theworker02:fix/ftp-uri-credentials
Open

theworker02 wants to merge 1 commit into
files-community:mainfrom
theworker02:fix/ftp-uri-credentials

Conversation

@theworker02

Copy link
Copy Markdown

Resolved / Related Issues

Steps used to test these changes

  1. Ran dotnet build src/Files.App.Storage/Files.App.Storage.csproj --configuration Debug --arch x64 -v:quiet -clp:ErrorsOnly.
  2. Verified that FTP URIs with user info now create a NetworkCredential from the decoded URI username and password before falling back to saved or anonymous credentials.

Manual FTP-server verification was not performed in this environment.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hez2010 hez2010 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Before we can merge the PR, can you sign the CLA by clicking the CLA button on the above?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Use username and password from the FTP address instead of showing dialog

3 participants