Skip to content

temporal-sdk-migration [2/x]: temporal: support protobuf sharing with the official Ruby SDK - #9

Draft
yfang-figma wants to merge 1 commit into
masterfrom
yfang/temporal-protobuf-coexistence
Draft

yfang-figma wants to merge 1 commit into
masterfrom
yfang/temporal-protobuf-coexistence

Conversation

@yfang-figma

Copy link
Copy Markdown

Written with AI

Let the official SDK own Temporal protobuf messages when COINBASE_TEMPORAL_RUBY_DISABLE_PROTO_LOAD=1. Keep the Coinbase gRPC stubs and preserve default Coinbase-only loading. Apply the same guard after proto regeneration. This is a narrow adaptation of Coinbase PR 335, not an application-level require hook.

The option must be set before the first Coinbase require, after the official API classes load. It does not permit different Workflow runtimes to poll the same Task Queue. The official gem is a test dependency only.

Test plan

  • BUNDLE_GEMFILE=gemfiles/temporalio.gemfile bundle exec rspec spec/unit/lib/temporal/protobuf_loading_spec.rb: 2 examples pass. The dual-SDK regression fails on the original library files with duplicate protobuf descriptors.
  • The new probes plus existing gRPC and serializer specs pass: 74 examples, 0 failures, on Ruby 3.4.7 and temporalio 1.10.1.
  • Full unit suite with --require ostruct: 647 examples, 7 failures. The same 7 replay/backtrace failures reproduce with the original library files on Ruby 3.4. No unrelated fixes are included.
  • Proto regeneration was not run because the API submodule is absent in this checkout. make -n proto and git diff --check pass.

Application preload, fork, worker polling, and devenv01 validation belong to the dependent Figma investigation PRs.

temporal: support shared protobuf classes with official Ruby SDK
@yfang-figma yfang-figma changed the title temporal: support protobuf sharing with the official Ruby SDK temporal-sdk-migration [2/5]: temporal: support protobuf sharing with the official Ruby SDK Nov 4, 2026
@yfang-figma yfang-figma changed the title temporal-sdk-migration [2/5]: temporal: support protobuf sharing with the official Ruby SDK temporal-sdk-migration [2/x]: temporal: support protobuf sharing with the official Ruby SDK Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant