Repository navigation
temporal-sdk-migration [2/x]: temporal: support protobuf sharing with the official Ruby SDK - #9
Draft
yfang-figma wants to merge 1 commit into
Draft
yfang-figma wants to merge 1 commit into
yfang-figma wants to merge 1 commit into
Conversation
temporal: support shared protobuf classes with official Ruby SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written with AI
Let the official SDK own Temporal protobuf messages when
COINBASE_TEMPORAL_RUBY_DISABLE_PROTO_LOAD=1. Keep the Coinbase gRPC stubs and preserve default Coinbase-only loading. Apply the same guard after proto regeneration. This is a narrow adaptation of Coinbase PR 335, not an application-level require hook.The option must be set before the first Coinbase require, after the official API classes load. It does not permit different Workflow runtimes to poll the same Task Queue. The official gem is a test dependency only.
Test plan
BUNDLE_GEMFILE=gemfiles/temporalio.gemfile bundle exec rspec spec/unit/lib/temporal/protobuf_loading_spec.rb: 2 examples pass. The dual-SDK regression fails on the original library files with duplicate protobuf descriptors.--require ostruct: 647 examples, 7 failures. The same 7 replay/backtrace failures reproduce with the original library files on Ruby 3.4. No unrelated fixes are included.make -n protoandgit diff --checkpass.Application preload, fork, worker polling, and devenv01 validation belong to the dependent Figma investigation PRs.