Fixes & minor improvements#1091
Merged
RemDelaporteMathurin merged 13 commits intofenicsxfrom Mar 26, 2026
Merged
Conversation
This was
linked to
issues
Mar 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fenicsx #1091 +/- ##
===========================================
+ Coverage 94.80% 94.84% +0.04%
===========================================
Files 44 44
Lines 3194 3220 +26
===========================================
+ Hits 3028 3054 +26
Misses 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
There was a problem hiding this comment.
This change was needed because the Docker runs started to fail ...
jhdark
approved these changes
Mar 26, 2026
Comment on lines
+13
to
+15
| - name: Configure git safe directory | ||
| run: | | ||
| git config --global --add safe.directory '*' |
Collaborator
Author
There was a problem hiding this comment.
This was suggested by the error message in the Docker-based workflows.
see for instance this failed run
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
Processing /__w/FESTIM/FESTIM
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'error'
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [16 lines of output]
/tmp/pip-build-env-jgsrcgze/overlay/lib/python3.12/site-packages/vcs_versioning/_backends/_git.py:360: UserWarning: "/__w/FESTIM/FESTIM" is shallow and may cause errors
pre_parse(wd)
running egg_info
creating src/FESTIM.egg-info
writing src/FESTIM.egg-info/PKG-INFO
writing dependency_links to src/FESTIM.egg-info/dependency_links.txt
writing requirements to src/FESTIM.egg-info/requires.txt
writing top-level names to src/FESTIM.egg-info/top_level.txt
writing manifest file 'src/FESTIM.egg-info/SOURCES.txt'
/tmp/pip-build-env-jgsrcgze/overlay/lib/python3.12/site-packages/vcs_versioning/overrides.py:609: UserWarning: No GlobalOverrides context is active. Auto-creating one with SETUPTOOLS_SCM prefix for backwards compatibility. Consider using 'with GlobalOverrides.from_env("YOUR_TOOL"):' explicitly.
return get_active_overrides().subprocess_timeout
fatal: detected dubious ownership in repository at '/__w/FESTIM/FESTIM'
To add an exception for this directory, call:
git config --global --add safe.directory /__w/FESTIM/FESTIM
git introspection failed: fatal: detected dubious ownership in repository at '/__w/FESTIM/FESTIM'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
Notice: A new release of pip is available: 25.2 -> 26.0.1
Notice: To update, run: pip install --upgrade pip
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Error: Process completed with exit code 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR contains a few bug fixes (see below) and some minor improvements.
Related Issues
Fixes:
Profile1Dexport is not reset between 2 simulations #1076Motivation and Context
Type of Change
Testing
pytest)Code Quality Checklist
ruff format .)ruff check .)Documentation
Breaking Changes
Screenshots/Examples
Additional Notes