fix: respect ignored files during source discovery - #37
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Problem
Closes #21.
list_source_filesincorrectly yielded files listed in.insightignore, including sensitive files such as.env, so those files could be read and sent to the Gemini API. It also failed to discover standard extensionless source files such asDockerfileandMakefile.Changes
Dockerfile,Makefile,Containerfile, andJenkinsfilecase-insensitively.Tests
.venv\\Scripts\\python.exe -m pytest --basetemp=.pytest-tmp-final tests/ -q— 2 passed..venv\\Scripts\\python.exe -m py_compile setup.py insight\\__init__.py insight\\analyzer.py insight\\cli.py insight\\detector.py insight\\reporter.py insight\\utils.py— passed..venv\\Scripts\\python.exe -c "import insight"— passed..venv\\Scripts\\ruff.exe check insight\\utils.py tests\\test_utils.py --ignore UP024— passed..venv\\Scripts\\ruff.exe format --check tests\\test_utils.py— passed.Compatibility / Known limitations
The change preserves the existing extension matching behavior and adds only explicit filename matching for common extensionless source files. The upstream baseline currently reports 13 existing Ruff findings outside this change, including the pre-existing
UP024finding ininsight/utils.py; no unrelated cleanup is included here.Issue link
#21