Repository navigation
feat(clients): show and set PKCE and nonce requirements, warn when both are off - #338
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
seamless clients getshowsPKCE: required | not requiredandnonce: required | not required.seamless clients createandupdateaccept--pkce/--no-pkceand--nonce/--no-nonce. The shared@seamless-auth/typesschema checks the API's rules before the request is sent: PKCE can be turned off only on a confidential client, and the nonce only once PKCE is off.get,createandupdate. Inlistits row is markedno PKCE or nonce, followed by a count. Such a client relies only onstateand client authentication against authorization code injection.@seamless-auth/types0.34.0-next.4, where both fields are required in application responses.Closes #337
Checks
npm run build: passesnpm test: 1718 passed, 4 skippednpm run coverage: statements 99.05%, branches 96.72%, functions 98.69%, lines 99.32%