Repository navigation
feat(config): set hosted page branding from the CLI - #334
Merged
Merged
Conversation
Add seamless config hosted-ui get|set|reset (alias branding) for the hosted_ui system config key. set and reset read the current branding, merge the named fields, validate the result with HostedUiSchema from @seamless-auth/types and write the whole object back, since the API replaces it. hosted_ui is also writable whole through config set. A logo must be an https URL where the image is hosted. The API stores no files, so a local path is refused with that reason. Bump @seamless-auth/types to 0.34.0-next.2 and list the four new OpenID Provider keys as not yet writable (#332).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
seamless config hosted-ui get|set|reset(aliasbranding) to set and read back hosted page branding, and makeshosted_uiwritable whole throughconfig set hosted_ui '<json>'ornull.setandresetread the currenthosted_ui, change only the fields named, validate the result withHostedUiSchemafrom@seamless-auth/types, and send the whole object withPATCH /system-config/admin(admin write plus step-up), because the API replaces it rather than merging.The logo must be an https URL where the image is already hosted. The API stores no files and the schema takes only https URLs, so a local path,
file:ordata:value is refused with that reason. Logo upload would need hosting on the API or the provider service first; not in scope here.Bumps
@seamless-auth/typesto 0.34.0-next.2 and lists the four OpenID Provider keys as not yet writable (#332). Needs auth server v0.21 (fells-code/seamless-auth-api#532); merge with or after API 0.21.0. Overlaps #333 inpackage.jsonandsrc/core/systemConfig.ts; this branch'shosted_uientry should win.Closes #320
Checks
npm run build: passnpm test: 73 files, 1593 tests passnpm run coverage: thresholds met (99.34% lines, 96.61% branches)npm run check:types-current: pass