Repository navigation
fix: reject backslashes in WebSocket destination paths - #497
Merged
Merged
Conversation
Since @fastify/reply-from 12.8.1, HTTP requests whose decoded path contains a backslash are rejected with a 400, while WebSocket upgrades, which do not go through reply-from, still forwarded them. Reject raw and percent-encoded backslashes in validateDestination so HTTP, WebSocket and reply.fromParameters behave the same. Backslashes in the query string are still forwarded.
Tony133
approved these changes
Nov 14, 2026
Tony133
left a comment
Member
There was a problem hiding this comment.
LGTM
One non-blocking note: there is no WebSocket test for a raw backslash without .. (e.g. /pub/foo\bar). Might be worth adding one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
@fastify/reply-from12.8.1, plain HTTP requests whose decoded path contains a backslash are rejected with a400, but WebSocket upgrades don't go through reply-from and still forwarded paths such as/pub/foo%5Cbarto the upstream. This makesvalidateDestinationreject raw and percent-encoded backslashes in the path, so HTTP requests, WebSocket upgrades andreply.fromParametersall behave the same. Backslashes in the query string are still forwarded.The WebSocket test that expected
%5Cto be forwarded now expects a rejection on both transports, with a new control for a%5Cin the query string. ThehttpExpectedtest plumbing added in c32e69c is no longer needed and is removed. The README documents the behavior.This is a behavior change for WebSocket users who relied on encoded backslashes in paths.