Repository navigation
test: expect encoded backslashes to be rejected on the HTTP path - #496
Merged
Merged
Conversation
@fastify/reply-from 12.8.1 rejects destinations whose decoded path contains a backslash, so '/pub/foo%5Cbar' now gets a 400 on the HTTP path instead of being forwarded. WebSocket upgrades do not go through reply-from and still forward it unchanged. Update the expectations accordingly and require @fastify/reply-from ^12.8.1 so the tested behaviour matches the minimum supported version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fastify/reply-from12.8.1 rejects destinations whose decoded path contains a backslash, so three tests that expected/pub/foo%5Cbarto be proxied now fail onmainwith a fresh install: "HTTP paths cannot escape rewritePrefix", "reply.fromParameters cannot escape rewritePrefix" and "percent-encoded backslashes remain path data".The HTTP and
fromParameterstests now expect a 400 for the encoded backslash. In the WebSocket test, the upgrade still forwards/internal/foo%5C..barunchanged because WebSocket traffic does not go through reply-from, so only the plain-HTTP half of that test now expects an error. The@fastify/reply-fromrange is raised to^12.8.1so the tested behaviour matches the minimum supported version.