Repository navigation
fix: register body parser for text/plain to stream payloads - #494
Open
abdul-karim-mia wants to merge 2 commits into
Open
abdul-karim-mia wants to merge 2 commits into
abdul-karim-mia wants to merge 2 commits into
Conversation
This comment was marked as spam.
This comment was marked as spam.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #493
Context & Problem
As documented in the README:
Fastify core registers default content-type parsers for both
application/jsonandtext/plain. Previously,@fastify/http-proxyregistered its pass-throughbodyParserforapplication/jsonand wildcard*.Because Fastify routes exact content-type matches before wildcard parsers, requests with
content-type: text/plainmatched Fastify's built-in parser instead of being streamed to the destination. Consequently:text/plainpayloads in non-UTF-8 encodings (e.g. ISO-8859-1) were decoded as UTF-8 strings and corrupted.text/plainpayloads larger than the FastifybodyLimit(default 1 MiB) were rejected with413 FST_ERR_CTP_BODY_TOO_LARGEinstead of streaming.Solution
Register the pass-through
bodyParserfortext/plainalongsideapplication/jsonwhenopts.proxyPayloads !== false.Validation
test/test.jsverifying that non-UTF-8 bytes and bodies larger than 1 MiB are streamed to upstream without corruption or rejection.borp -C --check-coverage).npm test).