Skip to content

perf: Make Base.numerify single-pass and allocation-free per digit #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorshea wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

perf: Make Base.numerify single-pass and allocation-free per digit #3294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/faker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ class Base
ULetters = Array('A'..'Z')
LLetters = Array('a'..'z')
Letters = ULetters + LLetters
# Frozen digit strings, used to avoid allocating a new string for each
# random digit generated by #numerify.
DIGITS = %w[0 1 2 3 4 5 6 7 8 9].freeze

class << self
attr_reader :flexible_key
Expand All @@ -66,9 +69,15 @@ class << self

## by default numerify results do not start with a zero
def numerify(number_string, leading_zero: false)
return number_string.gsub('#') { rand(10).to_s } if leading_zero

number_string.sub('#') { rand(1..9).to_s }.gsub('#') { rand(10).to_s }
leading = !leading_zero
number_string.gsub('#') do
if leading
leading = false
DIGITS[rand(1..9)]
else
DIGITS[rand(10)]
end
end
end

def letterify(letter_string)
Expand Down