fix(schema): allow top level unknown properties#758
Open
gdulafactset wants to merge 1 commit intomainfrom
Open
fix(schema): allow top level unknown properties#758gdulafactset wants to merge 1 commit intomainfrom
gdulafactset wants to merge 1 commit intomainfrom
Conversation
|
Great job! No new security vulnerabilities introduced in this pull requestUse Checkmarx (@Checkmarx) to interact with Checkmarx PR Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the validation schema to allow top level unknown properties, so it doesn't error out on future properties introduced to the config. This is in preparation for the new
scopesproperty that will be introduced.Links
ENSC-2740
Testing
Run unit tests. Also tried locally, and this worked fine.
Checklist
Ensure the following things have been met before requesting a review: