Use valid FSE dictionary costs in optimal parser#4694
Open
Rohithmatham12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4681.
ZSTD_loadCEntropy()already marks dictionary FSE tables that contain zero-probability symbols asFSE_repeat_check, because they are not safe to assume valid for the full symbol range.ZSTD_rescaleFreqs()ignored those per-stream repeat modes and entered the dictionary-derived FSE pricing path whenever the Huffman table wasHUF_repeat_valid.For tiny dictionaries with optimal-parser strategies, that can make
FSE_getMaxNbBits()return its documented fake cost for zero-frequency symbols (tableLog + 1). WithscaleLog = 10, this reaches theassert(bitCost < scaleLog)in the optimal parser.This changes first-block optimal-parser pricing to decide per entropy stream:
That preserves dictionary-derived pricing when the table is known complete, while avoiding invalid costs from partial FSE tables.
Test plan:
make -j4 fuzzer./fuzzer -i1 -s1 -vgit diff --check