Move ntripper/stats to cmd/ntripper/stats#535
Open
leoleovich wants to merge 1 commit into
Open
Conversation
Summary: ntripper is a command-only tool: all of its logic lives in cmd/ntripper/main.go and there is no ntripper/ library package, so the top-level ntripper/ directory existed solely to hold the stats package. That stats package is imported only by cmd/ntripper. Move it under cmd/ntripper/stats to match the other command-only tools (cmd/ntpcheck/checker, cmd/ptpcheck/metrics, cmd/ziffy/node) and remove the orphan top-level ntripper/ directory. Updates the package_name, the import in main.go, and the BUCK dep accordingly. Also add an ntripper section to the top-level README so the command-line tool is documented alongside the related NTRIP/RTCM entries. ___ Differential Revision: D107570140
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@leoleovich has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107570140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ntripper is a command-only tool: all of its logic lives in
cmd/ntripper/main.go and there is no ntripper/ library package, so the
top-level ntripper/ directory existed solely to hold the stats package. That
stats package is imported only by cmd/ntripper.
Move it under cmd/ntripper/stats to match the other command-only tools
(cmd/ntpcheck/checker, cmd/ptpcheck/metrics, cmd/ziffy/node) and remove the
orphan top-level ntripper/ directory. Updates the package_name, the import in
main.go, and the BUCK dep accordingly.
Also add an ntripper section to the top-level README so the command-line tool
is documented alongside the related NTRIP/RTCM entries.
Differential Revision: D107570140