fix: clear correct timeout in attribute-behavior fixture#35820
fix: clear correct timeout in attribute-behavior fixture#35820sleitor wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @sleitor! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
…lUnmount componentWillUnmount called clearTimeout(this.interval) instead of clearTimeout(this.timeout), so the timeout was never actually cleared on unmount. Closes facebook#35814
29352f2 to
19d929a
Compare
Summary
componentWillUnmountin the attribute-behavior fixture callsclearTimeout(this.interval)instead ofclearTimeout(this.timeout). Sincethis.intervalis never assigned, the timeout set inonMouseEnteris never cleared on unmount.Fix: Change
this.interval→this.timeouton line 605.Closes #35814