Skip to content

fix: clear correct timeout in attribute-behavior fixture#35820

Open
sleitor wants to merge 1 commit intofacebook:mainfrom
sleitor:fix/fixture-clearTimeout
Open

fix: clear correct timeout in attribute-behavior fixture#35820
sleitor wants to merge 1 commit intofacebook:mainfrom
sleitor:fix/fixture-clearTimeout

Conversation

@sleitor
Copy link

@sleitor sleitor commented Feb 18, 2026

Summary

componentWillUnmount in the attribute-behavior fixture calls clearTimeout(this.interval) instead of clearTimeout(this.timeout). Since this.interval is never assigned, the timeout set in onMouseEnter is never cleared on unmount.

Fix: Change this.intervalthis.timeout on line 605.

Closes #35814

@meta-cla
Copy link

meta-cla bot commented Feb 18, 2026

Hi @sleitor!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

…lUnmount

componentWillUnmount called clearTimeout(this.interval) instead of
clearTimeout(this.timeout), so the timeout was never actually cleared
on unmount.

Closes facebook#35814
@sleitor sleitor force-pushed the fix/fixture-clearTimeout branch from 29352f2 to 19d929a Compare February 18, 2026 22:34
@meta-cla meta-cla bot added the CLA Signed label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Memory leak in attribute-behavior fixture - wrong variable cleared in componentWillUnmount

1 participant

Comments