Fix: Clear correct timeout variable in componentWillUnmount#35815
Fix: Clear correct timeout variable in componentWillUnmount#35815AmitSingh-5600 wants to merge 1 commit intofacebook:mainfrom
Conversation
Fixed a bug in fixtures/attribute-behavior/src/App.js where componentWillUnmount was checking for this.timeout but clearing this.interval (which doesn't exist). This caused a memory leak where timeouts weren't properly cleaned up on unmount, and could lead to React warnings about setState on unmounted components. Changed clearTimeout(this.interval) to clearTimeout(this.timeout) to match the conditional check and the rest of the component's timeout handling. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @AmitSingh-5600! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Description
Fixed a bug in
fixtures/attribute-behavior/src/App.jswhere thecomponentWillUnmountlifecycle method was checking forthis.timeoutbut incorrectly attempting to clearthis.interval.Since
this.intervalis undefined on this component, the actual timeout remained active, leading to potential memory leaks and React "setState" warnings if the timeout fired after the component had unmounted.Fix
Changed
clearTimeout(this.interval)toclearTimeout(this.timeout)to align with the conditional check and the variable used inonMouseEnter.Related Issues
Closes #35814
Checklist
mainyarnin the repository rootattribute-behaviorfixture