Respect theme enforceNavigationBarContrast attribute#56413
Open
zoontek wants to merge 1 commit intofacebook:mainfrom
Open
Respect theme enforceNavigationBarContrast attribute#56413zoontek wants to merge 1 commit intofacebook:mainfrom
enforceNavigationBarContrast attribute#56413zoontek wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
zoontek
changed the title
WindowCompat.enableEdgeToEdge() and respect theme enforceNavigationBarContrast attribute
facebook-github-tools
bot
added
the
Shared with Meta
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D100384656. |
zoontek
changed the title
WindowCompat.enableEdgeToEdge() and respect theme enforceNavigationBarContrast attributeenforceNavigationBarContrast attribute
zoontek
force-pushed
the
respect-system-bars-styles
branch
from
d78aed6 to
0ef7a32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds respect of the theme's
enforceNavigationBarContrastattribute inWindowUtilenableEdgeToEdge(this will allow us to delete our EdgeToEdgePackage.kt file, and prevent a glitch where the navigation bar is semi-opaque for a short instant when user explicitly setandroid:enforceNavigationBarContrasttofalse).Changelog:
[ANDROID] [CHANGED] - Respect theme
enforceNavigationBarContrastattributeTest Plan:
android:enforceNavigationBarContrasttotrue(default) andfalse).