Strip __deprecated_msg in the preprocessing#55970
Closed
coado wants to merge 1 commit intofacebook:mainfrom
Closed
Strip __deprecated_msg in the preprocessing#55970coado wants to merge 1 commit intofacebook:mainfrom
__deprecated_msg in the preprocessing#55970coado wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary:
Strips `__deprecated_msg` annotations due to incorrect parsing when in front of the interfaces (predefining does not help unfortunately). It doesn't fully solve the issue stated in the added test as doxygen also has problem with parsing interfaces for which the base class is in the new line.
```
interface Foo
: Bar<NSObject>
end
```
This will be handled by the fix in the doxygen.
This diff also adds stripping the `__deprecated` label which is again incorrectly parsed by doxygen.
Changelog:
[Internal]
Differential Revision: D95541064
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @coado in 0686cde When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Strips
__deprecated_msgannotations due to incorrect parsing when in front of the interfaces (predefining does not help unfortunately). It doesn't fully solve the issue stated in the added test as doxygen also has problem with parsing interfaces for which the base class is in the new line.This will be handled by the fix in the doxygen.
This diff also adds stripping the
__deprecatedlabel which is again incorrectly parsed by doxygen.Changelog:
[Internal]
Differential Revision: D95541064