Fix AccessibilityInfo.prefersCrossFadeTransitions unresolved promise

[chicio]

Summary:

This PR fixes a bug I found while exploring the codebase in the Components folder.

AccessibilityInfo exposes the method prefersCrossFadeTransitions. In the android branch, Promise.resolve(false) as return value was creating a new unrelated promise that never calls the resolve function provided by the promise executor constructor, so it was hangs indefinitely.

This means that if a user calls this method on android without any Platform.OS === ios guard, it will result in a unresolved promise.

I fixed the bug by aligning the implementation of prefersCrossFadeTransitions to the one of other methods (eg. isBoldTextEnabled).

I also added the tests to avoid regression, and additionally verify that the iOS method is doing what we are expecting (in both cases for when NativeAccessibilityManagerIOS.getCurrentPrefersCrossFadeTransitionsState is available or not).
The mock of the Platform object has been done the same way I saw while doing another contribution in the Pressability-test (see #55378 ).

I noticed the same bug in isHighTextContrastEnabled and isDarkerSystemColorsEnabled and I plan/would like to address them in follow-up PRs (and adding all the missing tests).

Changelog:

[GENERAL] [FIXED] - Fix AccessibilityInfo.prefersCrossFadeTransitions unresolved (never ending) promise

Test Plan:

This fix has been develop in TDD. I first added a failing test to reproduce that the android branch of the prefersCrossFadeTransitions method was acting as described above (resulting in failure due to jest timeout because the promise was not returning). Then I applied the fix, and finally added also the test for the iOS counterpart.

One final note: AccessibilityInfo is mocked globally in setup.js (via setupFiles in the Jest preset).
So to test the real implementation I had to use jest.unmock (pattern that I saw is already used in other component test files like View-test.js and TextInput-test.js).

[chicio]

Hi @vzaidman, sorry to bother you. I see you were one of the last dev working on this piece of code (to improve the error description). Maybe you can help me to import this PR if the fix I made it makes sense? Thank you so much for your help 🙏.

[cipolleschi]

Thanks for fixing this accessibility issue

[meta-codesync]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D95565605.

[chicio]

Thanks for fixing this accessibility issue

Thank you for the review @cipolleschi!!! 🙏Tomorrow/in the next days I will open other PRs to fix the other problematic methods in AccessibilityInfo with the same problem (and I think also a part of the doc is not aligned, I will check how to update it).

Ps let me know if I have to do anything else before merging/to make this land in the main branch.

[react-native-bot]

This pull request was successfully merged by @chicio in 57c073f

^{When will my fix make it into a release? | How to file a pick request?}

[meta-codesync]

@cipolleschi merged this pull request in 57c073f.