Apply custom headers in RCTReconnectingWebSocket#55591
Open
cortinico wants to merge 6 commits intofacebook:mainfrom
Open
Apply custom headers in RCTReconnectingWebSocket#55591cortinico wants to merge 6 commits intofacebook:mainfrom
cortinico wants to merge 6 commits intofacebook:mainfrom
Conversation
Summary: Add a thread-safe singleton that holds custom HTTP headers to be applied to all iOS devsupport network requests. This mirrors the Android `DevSupportHttpClient` from D93481539. Uses a GCD concurrent queue with barrier writes for reader-writer synchronization. Differential Revision: D93490954
Summary: Inject custom devsupport headers into bundle download requests. This ensures that multipart bundle fetches include any headers registered via `RCTDevSupportHttpHeaders`. Differential Revision: D93490951
Summary: Inject custom devsupport headers into the packager status check request. Changes NSURLRequest to NSMutableURLRequest to allow header mutation before the request is sent. Differential Revision: D93490952
Summary: Inject custom devsupport headers into the open-debugger POST request. This ensures the debugger launch request includes any registered custom headers. Differential Revision: D93490950
Summary: Inject custom devsupport headers into inspector resource loading requests. This ensures that inspector network fetches include any registered custom headers. Differential Revision: D93490953
Summary: Inject custom devsupport headers into the HMR WebSocket connection. Changes from `initWithURL:` to `initWithURLRequest:` so headers can be set on the HTTP upgrade handshake. Differential Revision: D93490948
meta-cla
bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93490948. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Inject custom devsupport headers into the HMR WebSocket connection. Changes from
initWithURL:toinitWithURLRequest:so headers can be set on the HTTP upgrade handshake.Differential Revision: D93490948