Fix TextInput isFocused false positive on stale refs after unmount#55570
Closed
chicio wants to merge 2 commits intofacebook:mainfrom
Closed
Fix TextInput isFocused false positive on stale refs after unmount#55570chicio wants to merge 2 commits intofacebook:mainfrom
chicio wants to merge 2 commits intofacebook:mainfrom
Conversation
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this in D94076114. |
Contributor
Author
|
Hi @NickGerleman , thank you so much for importing my PR! 🙏 |
Collaborator
|
This pull request was successfully merged by @chicio in 42cd0f0 When will my fix make it into a release? | How to file a pick request? |
|
@NickGerleman merged this pull request in 42cd0f0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a false positive in in the
TextInputcomponent in theisFocusedmethod.Before the modification I made in this PR, the
isFocusedwas (wrongly) returning true if bothTextInputState.currentlyFocusedInput()andinputRef.current(inTextInput) werenull. This can happen eg. when aTextInputis never focused and a stalerefis checked after unmount.This fix adds an explicit not null check for
TextInputState.currentlyFocusedInput(). I also added some tests to cover the unmount scenarios, including:Changelog:
[GENERAL] [FIXED] - Fixed isFocused false positive
Test Plan:
TextInput-itest.jsfantom test and verify all tests cases passed (yarn fantom TextInput-itest)