HTTPTransaction: reject WT streams and datagrams after ingress complete#612
Open
afrind wants to merge 1 commit intofacebook:mainfrom
Open
HTTPTransaction: reject WT streams and datagrams after ingress complete#612afrind wants to merge 1 commit intofacebook:mainfrom
afrind wants to merge 1 commit intofacebook:mainfrom
Conversation
onWebTransportUniStream and onWebTransportBidiStream had no guard against delivery after the session stream ends, unlike onDatagram which is already gated by the ingress state machine. Add isIngressComplete() checks to both so that WT streams arriving in the window between session-end and transaction teardown are aborted at the transport level rather than dispatched to the handler. Add HQDownstreamSessionTestWebTransport/WTUniStreamRejectedAfterSessionEnd to verify the guard: a WT uni-stream injected after client FIN must not reach the handler. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@joanna-jo has imported this pull request. If you are a Meta employee, you can view this in D101840391. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onWebTransportUniStream and onWebTransportBidiStream had no guard against delivery after the session stream ends, unlike onDatagram which is already gated by the ingress state machine. Add isIngressComplete() checks to both so that WT streams arriving in the window between session-end and transaction teardown are aborted at the transport level rather than dispatched to the handler.
Add HQDownstreamSessionTestWebTransport/WTUniStreamRejectedAfterSessionEnd to verify the guard: a WT uni-stream injected after client FIN must not reach the handler.