option to use a particular trial for CV test set (#4996)#4996
Closed
bletham wants to merge 3 commits intofacebook:mainfrom
Closed
option to use a particular trial for CV test set (#4996)#4996bletham wants to merge 3 commits intofacebook:mainfrom
bletham wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4996 +/- ##
========================================
Coverage 96.29% 96.29%
========================================
Files 611 611
Lines 67338 67451 +113
========================================
+ Hits 64846 64955 +109
- Misses 2492 2496 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bletham
force-pushed
the
export-D95824210
branch
from
40fe62e to
316efcd
Compare
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 10, 2026
Summary: In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Differential Revision: D95824210
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 10, 2026
Summary: Pull Request resolved: facebook#4996 In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Differential Revision: D95824210
bletham
force-pushed
the
export-D95824210
branch
from
316efcd to
ac5560c
Compare
meta-codesync
bot
changed the title
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 13, 2026
Summary: In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Reviewed By: mpolson64 Differential Revision: D95824210
bletham
force-pushed
the
export-D95824210
branch
from
ac5560c to
d6a418c
Compare
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 13, 2026
Summary: Pull Request resolved: facebook#4996 In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Reviewed By: mpolson64 Differential Revision: D95824210
bletham
force-pushed
the
export-D95824210
branch
from
d6a418c to
8270168
Compare
Differential Revision: D94553707
bletham
force-pushed
the
export-D95824210
branch
from
8270168 to
c5af417
Compare
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 23, 2026
Summary: In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Reviewed By: mpolson64 Differential Revision: D95824210
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 23, 2026
Summary: Pull Request resolved: facebook#4996 In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Reviewed By: mpolson64 Differential Revision: D95824210
bletham
force-pushed
the
export-D95824210
branch
from
c5af417 to
52d2c05
Compare
Differential Revision: D94707551
bletham
added a commit
to bletham/Ax
that referenced
this pull request
Mar 23, 2026
Summary: In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Reviewed By: mpolson64 Differential Revision: D95824210
bletham
force-pushed
the
export-D95824210
branch
from
52d2c05 to
46de52c
Compare
Summary: Pull Request resolved: facebook#4996 In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial. Reviewed By: mpolson64 Differential Revision: D95824210
bletham
force-pushed
the
export-D95824210
branch
from
46de52c to
3417375
Compare
|
This pull request has been merged in c8124ff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In situations where we have a target trial that is significantly different from other trials on the experiment, for instance if there was a system rebase in between two trials, we really care especially about our ability to predict the target trial, as that is what we expect to see moving forward. This adds a kwarg to the DiagnosticAnalysis to specify a particular trial for the diagnostics. All trials will still be used as train arms in each CV fold, but the test arms will be limited to arms in that trial.
Reviewed By: mpolson64
Differential Revision: D95824210